[PWGEM] Add optional PCM material-budget weights in PCMPCM#15139
Open
yelmardb wants to merge 8 commits intoAliceO2Group:masterfrom
Open
[PWGEM] Add optional PCM material-budget weights in PCMPCM#15139yelmardb wants to merge 8 commits intoAliceO2Group:masterfrom
yelmardb wants to merge 8 commits intoAliceO2Group:masterfrom
Conversation
yelmardb
requested review from
alibuild,
dsekihat,
jokonig,
m-c-danisch,
mhemmer-cern,
mikesas,
novitzky and
rbailhac
as code owners
github-actions
bot
changed the title
yelmardb
force-pushed
the
yelmard-pcmpcm-omega-mb-weights
branch
3 times, most recently
from
af257e1 to
9476160
Compare
mhemmer-cern
requested changes
Feb 24, 2026
Collaborator
yelmardb
force-pushed
the
yelmard-pcmpcm-omega-mb-weights
branch
from
811cfa0 to
12fbfb5
Compare
yelmardb
added a commit
to yelmardb/O2Physics
that referenced
this pull request
Mar 11, 2026
Please consider the following formatting changes to AliceO2Group#15139
yelmardb
force-pushed
the
yelmard-pcmpcm-omega-mb-weights
branch
from
2f485d9 to
fed7576
Compare
added 4 commits
March 11, 2026 16:54
Add a V0 photon material-budget weight table (Omega MB weights) and join it in the PCMPCM pi0/eta workflow. The weights are applied only when the joined column is available, using compile-time guarded access. Introduce a configurable switch (runWithMBWeights) in MaterialBudgetWeights: - false: no CCDB query, write weight=1 - true: require CCDB histogram and abort if missing
yelmardb
force-pushed
the
yelmard-pcmpcm-omega-mb-weights
branch
from
fed7576 to
8b00868
Compare
Collaborator
|
@yelmardb Why don't you just merge the automatic formatting PR instead of attempting to fix it manually? |
mhemmer-cern
requested changes
Mar 11, 2026
Collaborator
mhemmer-cern
left a comment
mhemmer-cern
left a comment
There was a problem hiding this comment.
Two minor comments
mhemmer-cern
requested changes
Mar 11, 2026
Collaborator
mhemmer-cern
left a comment
mhemmer-cern
left a comment
There was a problem hiding this comment.
One more comment. The adaptAnalysisTask<MaterialBudgetWeights>(cfgc) lines in the Pi0EtaToGammaGammaXXX.cxx files should not be there. The materialBudgetWeights.cxx is already taking care of it.
| WorkflowSpec defineDataProcessing(ConfigContext const& cfgc) | ||
| { | ||
| return WorkflowSpec{ | ||
| adaptAnalysisTask<MaterialBudgetWeights>(cfgc), |
Collaborator
There was a problem hiding this comment.
I think this line should not be here
| WorkflowSpec defineDataProcessing(ConfigContext const& cfgc) | ||
| { | ||
| return WorkflowSpec{ | ||
| adaptAnalysisTask<MaterialBudgetWeights>(cfgc), |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a V0 photon material-budget weight table (Omega MB weights) and join it in the PCMPCM pi0/eta workflow. The weights are applied only when the joined column is available, using compile-time guarded access.
Introduce a configurable switch (runWithMBWeights) in MaterialBudgetWeights: